Skip to content

Conversation

@masonwheeler
Copy link
Contributor

Fixes #63227.

@ghost ghost added area-Tools-ILVerification Issues related to ilverify tool and IL verification in general community-contribution Indicates that the PR has been added by a community member labels Dec 31, 2021
@ghost
Copy link

ghost commented Dec 31, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #63227.

Author: masonwheeler
Assignees: -
Labels:

area-ILVerification

Milestone: -

@MichalStrehovsky
Copy link
Member

The reason I suggested putting this check into FindBasicBlocks is because IlImporter.cs is shared with multiple projects and this would make sure they all handle it instead of throwing the boneheaded exception.

This fix works for IlVerify but the benefit is limited.

@JulieLeeMSFT
Copy link
Member

@MichalStrehovsky if you reviewed the code, could you approve the code to merge it? Thanks.

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky if you reviewed the code, could you approve the code to merge it? Thanks.

This fix works around a bug in FindBasicBlocks. I would prefer FindBasicBlocks to be fixed instead because we have multiple users of that code. @masonwheeler would you be willing to change it to that instead?

@JulieLeeMSFT JulieLeeMSFT added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 25, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jan 25, 2022
@ghost ghost added the no-recent-activity label Feb 8, 2022
@ghost
Copy link

ghost commented Feb 8, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost
Copy link

ghost commented Feb 23, 2022

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Feb 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILVerification Issues related to ilverify tool and IL verification in general community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad data can cause ILVerify to throw IndexOutOfRangeException

3 participants