Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Interesting. Most seem to be testing types in the DLR / CSharp dynamic binder code which effectively we own. Looks like a handful of other types hit this but it is more common than I would've expected. |
|
Can we just fix the casing? I assume they're all internal and we wouldn't write new code this way. Unless you want to dog food your warning. |
That's an option too, but is a bit more work. So you tell me what you'd like ;-) |
|
I'd prefer to upper case them all, but if that's a hassle this change is OK to me. |
|
Thanks for letting me know. I'll take a stab. |
|
How should |
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsA warnlevel 7 warning is being added in VS 17.1 / SDK 6.0.200 to warn about lower-cased ascii type names. (See PR).
|
I'd prefer to leave these lower-cased. We have a policy that types/functions declared in C# for interop should mirror the native naming, as if we were able to simply reference a .h file. On Unix, that invariably means lower-cased names. |
|
Then |
This reverts commit 1b31d9f.
Similarly my preference is for those to remain lower-cased as well. |
|
merged with libraries builds failing, affecting everyone else |
A warnlevel 7 warning is being added in VS 17.1 / SDK 6.0.200 to warn about lower-cased ascii type names. (See PR).