Nonzero Exit Code for performance-setup Failures#59483
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tohron
commented
Sep 22, 2021
Tohron
commented
Sep 22, 2021
billwert
reviewed
Sep 22, 2021
billwert
reviewed
Sep 23, 2021
Member
|
@Tohron Since we have so much repeated code in these scripts from the error checking, I think that it would be useful to write a function that takes in the command we want to check, and then does the error level checking. This would greatly simplify the code, and make adding new checks much easier. |
billwert
reviewed
Sep 30, 2021
billwert
reviewed
Sep 30, 2021
billwert
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created to address dotnet/performance#2010
This PR aims to cause performance-setup.ps1 and performance-setup.sh to return a nonzero exit code whenever a command in the script fails.