Merged
Conversation
|
Tagging subscribers to this area: @buyaa-n, @krwq Issue Detailsnull
|
Wraith2
reviewed
Sep 22, 2021
src/libraries/System.Private.Xml/src/System/Xml/Xslt/XslCompiledTransform.cs
Show resolved
Hide resolved
Wraith2
approved these changes
Sep 27, 2021
Contributor
Wraith2
left a comment
There was a problem hiding this comment.
LGTM in general. As usual I'm not a fan of the unscoped using but that's for the maintainers to decide on.
krwq
reviewed
Sep 30, 2021
| CheckArguments(input, results); | ||
| CheckCommand(); | ||
| _command.Execute((object)input, documentResolver, arguments, results); | ||
| _command!.Execute(input, documentResolver, arguments, results); |
Member
There was a problem hiding this comment.
why ! hasn't been needed before but it is now?
krwq
reviewed
Sep 30, 2021
| Reset(); | ||
| CompileXsltToQil(stylesheet, settings, stylesheetResolver); | ||
| return _qil; | ||
| return _qil!; |
Member
There was a problem hiding this comment.
why ! hasn't been needed before and it is now?
krwq
approved these changes
Sep 30, 2021
Member
krwq
left a comment
There was a problem hiding this comment.
LGTM after comments are resolved
Contributor
Author
|
@krwq I`m removed unused methods. could you run tests? |
krwq
approved these changes
Oct 1, 2021
Member
|
/azp list |
Member
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
none of the outerloop test failures look related so LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.