Add tests for notification profilers#57429
Conversation
|
Tagging subscribers to this area: @tommcdon Issue DetailsAdd CI tests for notification profilers, and fix a couple things to make life with multiple profilers easier
|
| IDS_E_PROF_NOT_ATTACHABLE "Loading profiler failed. The profiler COM object was instantiated, but the profiler does not support attaching to a live process. The profiler must be loaded at application startup by using a launcher program included with the profiler (if any) or by setting the COR_ENABLE_PROFILING and COR_PROFILER environment variables before launching the application to be profiled. Profiler CLSID: '%s'" | ||
| IDS_E_PROF_UNHANDLED_EXCEPTION_ON_LOAD "Loading profiler failed. There was an unhandled exception while trying to instantiate the profiler COM object. Please ensure the CLSID is associated with a valid profiler designed to work with this version of the runtime. Profiler CLSID: '%s'." | ||
| IDS_PROF_ATTACH_REQUEST_RECEIVED "The CLR received a request to attach a profiler. Profiler CLSID: '%s'." | ||
| IDS_PROF_DETACH_INITIATED "The profiler currently in use has requested to be detached from the process. The CLR has disabled communication with the profiler and will unload the profiler when it is safe to do so." |
There was a problem hiding this comment.
Any reason to new line these? All others don't.
There was a problem hiding this comment.
They are printed to the debugger and without a newline it would get printed all on one line. I added newlines to all the profiler ones so they are consistent
| return clsid; | ||
| } | ||
|
|
||
| HRESULT MultiplyLoaded::InitializeCommon(IUnknown* pICorProfilerInfoUnk) |
There was a problem hiding this comment.
nit: Should this be multiple instead of multiply?
There was a problem hiding this comment.
I was using multiply as an adverb, not a verb 😄
|
The one remaining failure is unrelated to my changes, going to merge now |
Add CI tests for notification profilers, and fix a couple things to make life with multiple profilers easier