Skip to content

Fix compile issue with escaped characters in logging generator message#57379

Merged
danmoseley merged 1 commit intodotnet:mainfrom
maryamariyan:fix-escape
Aug 14, 2021
Merged

Fix compile issue with escaped characters in logging generator message#57379
danmoseley merged 1 commit intodotnet:mainfrom
maryamariyan:fix-escape

Conversation

@maryamariyan
Copy link
Contributor

Fixes: #56203

@maryamariyan maryamariyan added this to the 6.0.0 milestone Aug 13, 2021
@maryamariyan maryamariyan requested a review from eerhardt August 13, 2021 21:52
@maryamariyan maryamariyan self-assigned this Aug 13, 2021
@ghost
Copy link

ghost commented Aug 13, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #56203

Author: maryamariyan
Assignees: maryamariyan
Labels:

area-Extensions-Logging

Milestone: 6.0.0

@maryamariyan maryamariyan requested a review from tarekgh August 13, 2021 22:17
@ghost
Copy link

ghost commented Aug 13, 2021

Hello @maryamariyan!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@danmoseley
Copy link
Member

Failures are from #57221

@danmoseley danmoseley merged commit 224d202 into dotnet:main Aug 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LoggerMessageAttribute generated source does not respect escaped characters and does not compile

3 participants