Fix fgRemoveUnreachableBlocks to detect all changes#57199
Merged
jakobbotsch merged 3 commits intodotnet:mainfrom Aug 12, 2021
Merged
Fix fgRemoveUnreachableBlocks to detect all changes#57199jakobbotsch merged 3 commits intodotnet:mainfrom
jakobbotsch merged 3 commits intodotnet:mainfrom
Conversation
When 'removing' a BBF_DONT_REMOVE block we change it to BBJ_THROW. After this it is possible that other blocks become unreachable, so we should keep looking for such blocks. In dotnet#57061 that manifested in a case where the unreachable block did not have SSA built for it, but downstream the compiler was relying on SSA being built. Fix dotnet#57061
Member
Author
|
cc @dotnet/jit-contrib |
Member
Author
|
No instruction diffs in x64/x86/ARM32 SPMI, but there are a few GC info diffs because we mark some functions as partially interruptible instead of fully interruptible now. |
EgorBo
reviewed
Aug 11, 2021
AndyAyersMS
approved these changes
Aug 11, 2021
Member
AndyAyersMS
left a comment
There was a problem hiding this comment.
We should also consider ways to harden downstream code so that it does not depend on unreachable blocks being removed.
Member
Author
|
I'll merge this now and submit a separate change to harden VN/loop opts for trees that might not have had SSA built for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When 'removing' a BBF_DONT_REMOVE block we change it to BBJ_THROW. After
this it is possible that other blocks become unreachable, so we should
keep looking for such blocks.
In #57061 that manifested in a case where the unreachable block did not
have SSA built for it, but downstream the compiler was relying on SSA
being built.
Fix #57061
cc @dotnet/jit-ctontrib