Shouldn't AssemblyVersion be set outside of this file so that it also applies to reference assemblies and source generators assemblies (the latter doesn't import this file as they aren't packable)?

Shouldn't AssemblyVersion be set outside of this file so that it also applies to reference assemblies and source generators assemblies (the latter doesn't import this file as they aren't packable)?

we don`t need to update the reference assemblies as we never change them in servicing and anyway we are not shipping them in 6.0.
For generators assemblies, we will have to decide if we want to always increment with the package or only when we make a change in generator.

Shouldn't AssemblyVersion be set outside of this files

Instead i will suggest to add the packaging.targets file to analyzers as well. (using IsNETCoreAppAnalyzer property)

are any of the analyzers part of the shared framework ?

are any of the analyzers part of the shared framework ?

Yes, the System.Text.Json one is part of the shared framework.

Instead i will suggest to add the packaging.targets file to analyzers as well. (using IsNETCoreAppAnalyzer property)

Analyzers aren't packable themselves so it doesn't make sense for them to import packaging.targets. The code in that file is specific to projects which pack. I would keep the PackageVersion property in packaging.props and move the AssemblyVersion sectionout and make sure that it applies to both source projects and analyzers.

For generators assemblies, we will have to decide if we want to always increment with the package or only when we make a change in generator.

My gut feeling says that we should keep the AssemblyVersion of source assemblies in sync with their source generators. For that we might need two more properties in NetCoreAppLibrary.props (btw we should change that file's name at some point): AspNetCoreAppAnalyzer and NetCoreAppAnalyzer.

Putting more thought into this, I don't think that introducing properties for analyzers in NetCoreAppLibrary.props is necessary. It is probably easier to apply the same assembly version to both the source assembly and the analyzer assembly.

If the project is a generator project you would need to check if the "corresponding" source assembly is part of any shared framework.

For now all existing source generators are shipping as part of a shared framework (either netcoreapp or aspnetcoreapp) so if this becomes to complicated to implement you might just ignore them for 6.0 and never increment their assembly version.

If you want to go down that path then your PR in its current state is probably sufficient.