Disable System.Drawing.Common tests for mobile workloads and skip a few other tests by steveisok · Pull Request #57114 · dotnet/runtime

steveisok · 2021-08-10T04:27:11Z

Since the library is PNSE by default, make sure the tests do not run on mobile.
Also skips a few other tests.

Since the library is PNSE by default, make sure the tests do not run on mobile.

ghost · 2021-08-10T04:27:17Z

Tagging subscribers to this area: @safern, @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details

Since the library is PNSE by default, make sure the tests do not run on mobile.

Author:	steveisok
Assignees:	-
Labels:	`area-System.Drawing`
Milestone:	-

danmoseley · 2021-08-10T05:05:12Z

Should we have some shorthand property for '$(TargetOS)' == 'Browser' or '$(TargetOS)' == 'Android' or '$(TargetOS)' == 'iOS' or '$(TargetOS)' == 'iOSSimulator' or '$(TargetOS)' == 'tvOS' or '$(TargetOS)' == 'tvOSSimulator' or '$(TargetOS)' == 'MacCatalyst'? Or the same, without Browser. They often seem to go together.

…running for mobile tests

mdh1418 · 2021-08-10T14:01:34Z

eng/testing/tests.mobile.targets

             AssemblyFile="$(RuntimeConfigParserTasksAssemblyPath)"
             Condition="'$(RuntimeConfigParserTasksAssemblyPath)' != ''" />

-  <Target Name="GenerateRuntimeConfig" Condition="'$(OutputType)' != 'library' and '$(TargetOS)' != 'Browser'">


Out of curiosity, why do we no longer need this, or why was it introduced in the first place?

I think it was introduced by mistake from #56486

why are we skipping it on browser

Good question. @fanyang-mono ?

Wasm has its own target of generating runtime config which is part of the source code. (https://github.com/dotnet/runtime/blob/main/src/mono/wasm/build/WasmApp.targets#L146) This target is for mobile testing only. But for wasm testing, the targets defined in this file will be visible to wasm tests as well. To make things clear, I added '$(TargetOS)' != 'Browser'.

lewing · 2021-08-10T15:08:40Z

browser failed with

Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[13:59:16] info: browser: Console websocket connected.
[13:59:16] info: Arguments: --run,WasmTestRunner.dll,System.ServiceModel.Syndication.Tests.dll,-notrait,category=IgnoreForCI,-notrait,category=OuterLoop,-notrait,category=failing
[13:59:18] info: Initializing.....
[13:59:26] info: Discovering: System.ServiceModel.Syndication.Tests.dll (method display = ClassAndMethod, method display options = None)
[13:59:26] info: Discovered:  System.ServiceModel.Syndication.Tests.dll (found 776 of 776 test cases)
[13:59:26] info: Starting:    System.ServiceModel.Syndication.Tests.dll
[13:59:26] fail: [FAIL] System.ServiceModel.Syndication.Tests.Atom10ItemFormatterTests.WriteTo_EmptyItem_SerializesExpected
[13:59:26] info: Assert.True() Failure
[13:59:26] info: Expected: True
[13:59:26] info: Actual:   False
[13:59:26] info:    at System.ServiceModel.Syndication.Tests.Atom10ItemFormatterTests.WriteTo_EmptyItem_SerializesExpected()
[13:59:26] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[13:59:26] info: Finished:    System.ServiceModel.Syndication.Tests.dll
[13:59:26] info: 
[13:59:26] info: === TEST EXECUTION SUMMARY ===
[13:59:26] info: Total: 1308, Errors: 0, Failed: 1, Skipped: 0, Time: 5.8885999s

which is something I have not seen before

lewing · 2021-08-10T15:10:01Z

monointerpreter failed with

System.InvalidOperationException: Collection was modified after the enumerator was instantiated.
   at System.Collections.Generic.Stack`1.Enumerator.MoveNext() in System.Collections.dll:token 0x6000267+0x1d
   at Xunit.Sdk.DisposalTracker.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\DisposalTracker.cs:line 26
   at Xunit.Sdk.ExtensibilityPointFactory.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\ExtensibilityPointFactory.cs:line 53
   at Xunit.Sdk.TestFramework.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\TestFramework.cs:line 48
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__140_1(Object state) in System.Private.CoreLib.dll:token 0x6002da8+0x0
   at System.Threading.QueueUserWorkItemCallbackDefaultContext.Execute() in System.Private.CoreLib.dll:token 0x6002adc+0x14
   at System.Threading.ThreadPoolWorkQueue.Dispatch() in System.Private.CoreLib.dll:token 0x6002ab5+0x122
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart() in System.Private.CoreLib.dll:token 0x6002ba0+0x67
   at System.Threading.Thread.StartCallback() in System.Private.CoreLib.dll:token 0x600272e+0xe

Are we ever going to fix this? #11063

steveisok · 2021-08-10T15:16:23Z

Are we ever going to fix this? #11063

It would be nice.

src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj

src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/ConsoleLifetimeExitTests.cs

eerhardt · 2021-08-11T20:35:32Z

This will resolve #57184. We should close that issue when this is merged. Thanks for picking it up @steveisok.

src/libraries/System.Runtime/tests/System/CharTests.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

Disable System.Drawing.Common tests for mobile workloads

faa0a45

Since the library is PNSE by default, make sure the tests do not run on mobile.

steveisok requested a review from akoeplinger August 10, 2021 04:27

ghost added the area-System.Drawing label Aug 10, 2021

steveisok requested review from MaximLipnin, mdh1418 and safern August 10, 2021 04:27

danmoseley approved these changes Aug 10, 2021

View reviewed changes

Steve Pfister added 2 commits August 10, 2021 07:38

Shorter condition

f3cfb1d

Remove condition that prevents the GenerateRuntimeConfig target from …

33d157a

…running for mobile tests

mdh1418 reviewed Aug 10, 2021

View reviewed changes

mdh1418 approved these changes Aug 10, 2021

View reviewed changes

Properly skip some tests that were failing on CI

409a979

safern reviewed Aug 10, 2021

View reviewed changes

src/libraries/System.Drawing.Common/tests/System.Drawing.Common.Tests.csproj Show resolved Hide resolved

Go with santi's suggestion.

a792aac

safern approved these changes Aug 10, 2021

View reviewed changes

steveisok mentioned this pull request Aug 11, 2021

Microsoft.Extensions.Hosting.Tests.ConsoleLifetimeExitTests failing in Windows mono with PlatformNotSupportedException #57184

Closed

Skip platform specific test

ce7e54b

eerhardt reviewed Aug 11, 2021

View reviewed changes

src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/ConsoleLifetimeExitTests.cs Outdated Show resolved Hide resolved

src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/ConsoleLifetimeExitTests.cs Outdated Show resolved Hide resolved

steveisok mentioned this pull request Aug 12, 2021

PhysicalFileProvider: Avoid NullRef if ResolveLinkTarget returns null #57235

Merged

akoeplinger changed the title ~~Disable System.Drawing.Common tests for mobile workloads~~ Disable System.Drawing.Common tests for mobile workloads and skip a few other tests Aug 12, 2021

akoeplinger approved these changes Aug 12, 2021

View reviewed changes

src/libraries/System.Runtime/tests/System/CharTests.cs Outdated Show resolved Hide resolved

Apply suggestions from code review

09fea57

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>

steveisok merged commit defa26b into dotnet:main Aug 13, 2021

steveisok deleted the disable-drawing-ci-mobile branch August 13, 2021 01:37

runfoapp bot mentioned this pull request Aug 13, 2021

atom10itemformattertests.writeto_emptyitem_serializesexpected fails in CI #57375

Closed

ghost locked as resolved and limited conversation to collaborators Sep 12, 2021

Conversation

steveisok commented Aug 10, 2021 • edited by akoeplinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 10, 2021

Uh oh!

danmoseley commented Aug 10, 2021

Uh oh!

mdh1418 Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

steveisok Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

lewing Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

steveisok Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

fanyang-mono Aug 12, 2021

Choose a reason for hiding this comment

Uh oh!

lewing commented Aug 10, 2021

Uh oh!

lewing commented Aug 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveisok commented Aug 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eerhardt commented Aug 11, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

steveisok commented Aug 10, 2021 •

edited by akoeplinger

Loading

lewing commented Aug 10, 2021 •

edited

Loading