Skip to content

[wasm] Skip tests for ExpectContinue HTTP header#57058

Merged
pavelsavara merged 2 commits intodotnet:mainfrom
pavelsavara:wasm_pnse_http_100_continue
Aug 9, 2021
Merged

[wasm] Skip tests for ExpectContinue HTTP header#57058
pavelsavara merged 2 commits intodotnet:mainfrom
pavelsavara:wasm_pnse_http_100_continue

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Aug 9, 2021 •
edited
Loading

Expect: 100-continue header is not supported by any of the normal browsers.

See
Gecko issue
Chromium issue

Skip related tests fixes #53876

@ghost ghost added the area-System.Net.Http label Aug 9, 2021
@ghost
Copy link

ghost commented Aug 9, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Expect: 100-continue header is not supported by any of the normal browsers.

See
Gecko issue
Chromium issue

This change does:

  • throw PlatformNotSupportedException for ExpectContinue and Expect header fields on Browser
  • skip related tests
Author: pavelsavara
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Aug 9, 2021
@ghost
Copy link

ghost commented Aug 9, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Expect: 100-continue header is not supported by any of the normal browsers.

See
Gecko issue
Chromium issue

This change does:

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Net.Http
Milestone: -

@pavelsavara pavelsavara changed the title [wasm] PlatformNotSupportedException for ExpectContinue HTTP header [wasm] Skip tests for ExpectContinue HTTP header Aug 9, 2021
ManickaP
ManickaP approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@pavelsavara pavelsavara merged commit ae0e5e8 into dotnet:main Aug 9, 2021
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
@pavelsavara pavelsavara deleted the wasm_pnse_http_100_continue branch November 20, 2021 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@ManickaP ManickaP ManickaP approved these changes

@lewing lewing Awaiting requested review from lewing

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-System.Net.Http

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

[wasm] HttpRequestMessage.Headers.ExpectContinue is ignored on browser

4 participants

@pavelsavara @stephentoub @ManickaP @karelz