JIT: arm64 redundant move peephole must check instruction format#57016
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Aug 8, 2021
Merged
JIT: arm64 redundant move peephole must check instruction format#57016AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS merged 1 commit intodotnet:mainfrom
Conversation
Otherwise we may mistake an immediate for a register and do an incorrect optimization. Fixes dotnet#56689.
Member
Author
|
@kunalspathak PTAL No windows arm64 diffs (per cross-spmi from windows x64). No simple repro, unfortunately. |
Member
Author
|
x86 libraries failure (unrelated). osx innerloop failure |
Member
Author
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
FWIW this is the first time the libraries PGO leg has ever been green. |
kunalspathak
approved these changes
Aug 8, 2021
Contributor
kunalspathak
left a comment
There was a problem hiding this comment.
I can imagine the pain to get to the bottom of this! LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we may mistake an immediate for a register and do an incorrect
optimization.
Fixes #56689.