Fix x86 Linux build with clang < 10#55924
Merged
janvorli merged 1 commit intodotnet:mainfrom Jul 20, 2021
Merged
Conversation
There is a bug in clang that was fixed in version 10 and that causes the build of the src/coreclr/vm/i386/jithelp.S to fail with 'error: cannot use more than one symbol in memory operand'. The problem is that it doesn't support the `offset` keyword and it thinks it is just another symbol. The fix is to use att syntax for the offending instruction.
jkotas
approved these changes
Jul 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in clang that was fixed in version 10 and that causes
the build of the src/coreclr/vm/i386/jithelp.S to fail with
'error: cannot use more than one symbol in memory operand'.
The problem is that it doesn't support the
offsetkeyword andit thinks it is just another symbol.
The fix is to use att syntax for the offending instruction.
Close #55521