port system.diagnostics.performanceCounter#55134
Merged
ViktorHofer merged 2 commits intodotnet:mainfrom Jul 6, 2021
Anipik:performance
Merged
port system.diagnostics.performanceCounter#55134ViktorHofer merged 2 commits intodotnet:mainfrom Anipik:performance
ViktorHofer merged 2 commits intodotnet:mainfrom
Anipik:performance
Conversation
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue Details
Another example pr for reference.
|
58 tasks
ViktorHofer
reviewed
Jul 5, 2021
...aries/System.Diagnostics.PerformanceCounter/src/System.Diagnostics.PerformanceCounter.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jul 5, 2021
ViktorHofer
approved these changes
Jul 6, 2021
Member
|
Failures are due to work items being canceled which I pinged dnceng about in another issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another example pr for reference.
https://github.com/Anipik/PackagePortTester
i pushed the package validator which could be run on package paths to test if the port is successful.