Do not timeout HostingListener when debugging#54791
Merged
eerhardt merged 1 commit intodotnet:mainfrom Jun 27, 2021
Merged
Conversation
Do not timeout waiting for the host to start when running with the debugger attached. Addresses dotnet/aspnetcore#33886.
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsDo not timeout waiting for the host to start when running with the debugger attached (dotnet/aspnetcore#33886 (comment)). This only applies on first usage so the debugger must be already attached, otherwise will need refactoring so that the appropriate default is determined each time the value is used. Addresses dotnet/aspnetcore#33886. /cc @davidfowl
|
davidfowl
approved these changes
Jun 27, 2021
Member
|
sockets test failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not timeout waiting for the host to start when running with the debugger attached (dotnet/aspnetcore#33886 (comment)).
This only applies on first usage so the debugger must be already attached, otherwise will need refactoring so that the appropriate default is determined each time the value is used.
Fixes dotnet/aspnetcore#33886.
/cc @davidfowl