Fix SYSLIB obsoletion warnings in tests#51847
Merged
jeffhandley merged 2 commits intodotnet:mainfrom Apr 26, 2021
jeffhandley:jeffhandley/fix-39976
Merged
Fix SYSLIB obsoletion warnings in tests#51847jeffhandley merged 2 commits intodotnet:mainfrom jeffhandley:jeffhandley/fix-39976
jeffhandley merged 2 commits intodotnet:mainfrom
jeffhandley:jeffhandley/fix-39976
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes #39976 PR #39269 introduced warnings to the full build during .NET 5.0 when the
|
jkotas
reviewed
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39976
PR #39269 introduced warnings to the full build during .NET 5.0 when the
SYSLIBobsoletions were introduced. PR #42272 configured warnings to be treated as errors and achieved a clean build, but theSYSLIBdiagnostics were simply suppressed. This PR addresses theSYSLIBdiagnostics through targeted changes or in-place suppressions as appropriate and removes the<NoWarn>for them.