JIT: minor cleanups to the guarded devirtualization transform.#51769
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Apr 24, 2021
Merged
JIT: minor cleanups to the guarded devirtualization transform.#51769AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS merged 1 commit intodotnet:mainfrom
Conversation
Some small changes in anticipation of an upcoming bigger change. Should give a tiny boost to throughput and is (nearly) no diff. Don't bother creating a new block for the GDV test, it can sit at the end of the original block. Bash the original ret expr instead of leaving it referring to a temp local and/or nop.
Member
Author
|
cc @dotnet/jit-contrib One SPMI diff. Will attach details later. |
BruceForstall
approved these changes
Apr 23, 2021
Member
Author
There's a change in block ordering which leads to the diff. Oddly the flowgraph dump just before the point of divergent behavior is identical in base and diff, so it's some residual state in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small changes in anticipation of an upcoming bigger change.
Should give a tiny boost to throughput and is (nearly) no diff.
Don't bother creating a new block for the GDV test, it can sit at
the end of the original block.
Bash the original ret expr instead of leaving it referring to a temp
local and/or nop.