Add Mono System.Diagnostics.Tracing.RuntimeEventSource.#51734
Merged
lateralusX merged 12 commits intodotnet:mainfrom Apr 26, 2021
Merged
Add Mono System.Diagnostics.Tracing.RuntimeEventSource.#51734lateralusX merged 12 commits intodotnet:mainfrom
lateralusX merged 12 commits intodotnet:mainfrom
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vargaz
reviewed
Apr 23, 2021
src/mono/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.xml
Outdated
Show resolved
Hide resolved
vargaz
reviewed
Apr 23, 2021
marek-safar
reviewed
Apr 23, 2021
marek-safar
reviewed
Apr 24, 2021
src/mono/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.xml
Outdated
Show resolved
Hide resolved
dca3011 to
43ce788
Compare
vargaz
approved these changes
Apr 25, 2021
marek-safar
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mono didn't register RuntimeEventSource on startup and was missing a number of runtime specific counters. This PR implements support for all current counters in RuntimeEventSource on Mono runtime. Below screenshot is running dotnet-counters against a dummy app with an infinite loop just throwing exception and GC.Collect(2) on Windows Mono runtime with this PR: