Skip to content

JIT: fix BasicBlock::isEmpty()#51340

Merged
BruceForstall merged 1 commit intodotnet:mainfrom
AndyAyersMS:Fix51326
Apr 16, 2021
Merged

JIT: fix BasicBlock::isEmpty()#51340
BruceForstall merged 1 commit intodotnet:mainfrom
AndyAyersMS:Fix51326

Conversation

@AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Apr 15, 2021

The detection of blocks with only PHI assignments was broken by #50806.
Fix by using existing helper to find the first non-PHI assignment.

Closes #51326.

@AndyAyersMS
JIT: fix BasicBlock::isEmpty()
91cf8b3 
The detection of blocks with only PHI assignments was broken by dotnet#50806.
Fix by using existing helper to find the first non-PHI assignment.

Closes dotnet#51326.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 15, 2021
@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Apr 15, 2021

@BruceForstall PTAL
cc @dotnet/jit-contrib

Will kick off jit stress for this PR shortly.

BruceForstall
BruceForstall approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Apr 15, 2021

One asm diff via SPMI (RA making different choices), a few text diffs (likely block weight shifts).

@AndyAyersMS AndyAyersMS self-assigned this Apr 15, 2021
@AndyAyersMS AndyAyersMS added this to the 6.0.0 milestone Apr 15, 2021
@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Apr 16, 2021

Arm32 tests passed, but CI failed to report success:

=== TEST EXECUTION SUMMARY ===
   JIT.Regression.XUnitWrapper  Total: 152, Errors: 0, Failed: 0, Skipped: 0, Time: 26.731s
...
  WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0xeaa1ebf0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution',)': /simple/azure-devops/
...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 1800 seconds and was killed
['JIT.Regression.CLR-x86-JIT.V1-M12-M13' WORK ITEM LOG TRUNCATED: Command timed out, and was killed]

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Apr 16, 2021

Jitstress ongoing, one failure so far, in coreroot_determinism.sh.

@AndyAyersMS
Copy link
Member Author

AndyAyersMS commented Apr 16, 2021

Also seeing the burgers failure #51293.

@BruceForstall
Copy link
Contributor

BruceForstall commented Apr 16, 2021

Failures are known

@BruceForstall BruceForstall merged commit 70a78f9 into dotnet:main Apr 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AndyAyersMS AndyAyersMS

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Assertion failed 'this->bbNext->isEmpty()'

2 participants

@AndyAyersMS @BruceForstall