Expose Adjustment Rule BaseUtcOffsetDelta#51055
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
CC @gewarren for the doc part. |
|
|
||
| try | ||
| { | ||
| string id = $"Etc/GMT{i:+0;-0}"; |
There was a problem hiding this comment.
This formatting is going to be subject to the current culture, which could impact the negative sign used. Is that going to be an issue for someone running the tests in, say, Sweden?
There was a problem hiding this comment.
It is possible to fail. As this is not related to this PR, we can address that in another PR.
In reply to: 611643769 [](ancestors = 611643769)
gewarren
left a comment
There was a problem hiding this comment.
I left some /// suggestions only.
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.AdjustmentRule.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
LGTM |
Fixes #50256