Update logic around BB_MAX_WEIGHT#51027
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Apr 10, 2021
Merged
Conversation
Consider any weight greater or equal to be a max weight. Rule of thumb is that you can assign BB_MAX_WEIGHT but for comparsions one should always use an inequality or call the helper method. Fixes dotnet#50808.
Member
Author
|
No SPMI diffs (looks like asp.net collection needs an update, I'll work on that). cc @dotnet/jit-contrib |
BruceForstall
approved these changes
Apr 9, 2021
Contributor
BruceForstall
left a comment
There was a problem hiding this comment.
How does this change anything if BB_MAX_WEIGHT is FLT_MAX? Is there anything greater? Does +infinity compare greater, and calculations saturate to +infinity?
Member
Author
|
Yes, We might want to set the maximum value lower; the largest we'll ever see from real PGO is maybe 10^12 or so. |
Member
Author
|
Innerloop failure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider any weight greater or equal to be a max weight. Rule of thumb
is that you can assign BB_MAX_WEIGHT but for comparsions one should always
use an inequality or call the helper method.
Fixes #50808.