Disable TestDynamicAssembly tests#50592
Merged
BruceForstall merged 1 commit intodotnet:mainfrom Apr 2, 2021
Merged
Conversation
These fail under GCStress. Issue: dotnet#48579
Contributor
Author
|
related: #49387 |
kunalspathak
reviewed
Apr 1, 2021
| TestDynamicAssembly(false); | ||
|
|
||
| // TestDynamicAssembly() disabled due to https://github.com/dotnet/runtime/issues/48579 | ||
| //TestDynamicAssembly(true); |
Contributor
There was a problem hiding this comment.
Are both the tests failing?
Contributor
Author
There was a problem hiding this comment.
Don't know. Some call to TestDefineDynamicAssembly fails. (Honestly, I don't care very much, since I'm ok with a "big hammer" if it's temporary, to get the CI running clean)
kunalspathak
approved these changes
Apr 1, 2021
Contributor
|
May be we should open a follow- up issue to reenable the test? |
Merged
Contributor
|
I have left a note in #49387 (comment). |
stephentoub
approved these changes
Apr 1, 2021
Contributor
Contributor
Author
|
I think the failure was in a PR-triggered run. Maybe there was something related to that? It hasn't failed in a main branch run. |
Contributor
Looks to be the case...I have pasted the historical test failure table in #48579 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fail under GCStress.
Issue: #48579