Clean up REGUTIL/CLRConfig system#50314
Merged
AaronRobinsonMSFT merged 5 commits intodotnet:mainfrom Mar 29, 2021
Merged
Conversation
jkotas
approved these changes
Mar 27, 2021
Member
jkotas
left a comment
There was a problem hiding this comment.
gcc build needs a bit of work. LGTM otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert all configuration options to use CLRConfig that still rely directly on REGUTIL.
Limit all uses of the REGUTIL code to the CLRConfig implementation.
Contributes toward #47283
Next PR is to remove Registry logic from REGUTIL and fold remaining implementation into CLRConfig.