Skip to content

Conversation

@eerhardt
Copy link
Member

Fix #37651

@eerhardt eerhardt added area-Infrastructure-libraries linkable-framework Issues associated with delivering a linker friendly framework labels Mar 24, 2021
@eerhardt eerhardt requested a review from joperezr March 24, 2021 23:28
@ghost
Copy link

ghost commented Mar 24, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #37651

Author: eerhardt
Assignees: -
Labels:

area-Infrastructure-libraries, linkable-framework

Milestone: -

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks for addressing this. In order to go one step further, I wonder if it would be good to add a bit of documentation on the meaning of these files perhaps somewhere in here https://github.com/dotnet/runtime/blob/3553284bea7b650874c8dcc3f78d6be085a047bb/docs/coding-guidelines/project-guidelines.md ? It doesn't need to happen as part of this PR, but that would just help to people not involved on the effort to understand why these files exist and what they are used for.

@eerhardt eerhardt merged commit 349abef into dotnet:main Mar 26, 2021
@eerhardt eerhardt deleted the RenameILLinkTrim branch March 26, 2021 20:22
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-libraries linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename ILLinkTrim.xml files to ILLink.Descriptors.xml

3 participants