[release/6.0-preview3] [AndroidCrypto] Implement X509 chain building - port of #49532#50135
Conversation
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsPort of #49532 to release/6.0-preview3 Customer ImpactWith #50107, the OpenSSL dependency will be removed from Android. This change enables X.509 certificate chain building functionality without OpenSSL on Android. The general effort around AndroidCrypto is on-going, but this will allow the major parts of System.Security.Cryptography to be in preview3. TestingTests in System.Security.Cryptography.X509Certificates for cert chains pass - except for one (fails to build a chain when it should succeed - would also fail without this change). RiskWhile the change itself is large, it is targeted to functionality didn't exist on Android the way it will actually ship (without OpenSSL), so the risk of breaking existing things is low.
|
|
can we get a Code review here before merging as it was not ported using the backport tool ? |
Port of #49532 to release/6.0-preview3
Customer Impact
With #50107, the OpenSSL dependency will be removed from Android. This change enables X.509 certificate chain building functionality without OpenSSL on Android. The general effort around AndroidCrypto is on-going, but this will allow the major parts of System.Security.Cryptography to be in preview3.
Testing
Tests in System.Security.Cryptography.X509Certificates for cert chains pass - except for one (fails to build a chain when it should succeed - would also fail without this change).
Risk
While the change itself is large, it is targeted to functionality didn't exist on Android the way it will actually ship (without OpenSSL), so the risk of breaking existing things is low.
cc @steveisok