Skip to content

Don't bundle the LLVM AOT optimizer on wasm we use the emscripten version#50132

Merged
lewing merged 1 commit intodotnet:mainfrom
lewing:wasm-no-aot-opt-bundle
Mar 24, 2021
Merged

Don't bundle the LLVM AOT optimizer on wasm we use the emscripten version#50132
lewing merged 1 commit intodotnet:mainfrom
lewing:wasm-no-aot-opt-bundle

Conversation

@lewing
Copy link
Member

@lewing lewing commented Mar 23, 2021 •
edited
Loading

used in mono.proj

      <_MonoRuntimeArtifacts Condition="'$(MonoAOTBundleLLVMOptimizer)' == 'true'" Include="$(MonoAOTLLVMDir)\bin\llc$(ExeExt)">
        <Destination>$(RuntimeBinDir)cross\$(PackageRID)\llc$(ExeExt)</Destination>
      </_MonoRuntimeArtifacts>
      <_MonoRuntimeArtifacts Condition="'$(MonoAOTBundleLLVMOptimizer)' == 'true'" Include="$(MonoAOTLLVMDir)\bin\opt$(ExeExt)">
        <Destination>$(RuntimeBinDir)cross\$(PackageRID)\opt$(ExeExt)</Destination>
      </_MonoRuntimeArtifacts>

to include llc and opt that aren't even built to support wasm right now

@lewing lewing requested a review from marek-safar as a code owner March 23, 2021 21:46
@ghost ghost added the area-Build-mono label Mar 23, 2021
@lewing lewing requested review from directhex and steveisok March 23, 2021 21:46
@lewing lewing merged commit 8dd8a43 into dotnet:main Mar 24, 2021
@lewing lewing mentioned this pull request Mar 24, 2021
Closed
@lewing lewing deleted the wasm-no-aot-opt-bundle branch March 24, 2021 02:58
@steveisok
Copy link
Member

steveisok commented Mar 24, 2021

/backport to release/6.0-preview3

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2021

Started backporting to release/6.0-preview3: https://github.com/dotnet/runtime/actions/runs/683452757

@github-actions github-actions bot mentioned this pull request Mar 24, 2021
Merged
@eerhardt eerhardt mentioned this pull request Mar 24, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@directhex directhex Awaiting requested review from directhex

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

Assignees

No one assigned

Labels

area-Build-mono

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lewing @steveisok @radical @karelz