Enable the latest managed pgo data#49793
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
@dotnet/crossgen-contrib |
AndyAyersMS
left a comment
There was a problem hiding this comment.
Jit changes ok (per offline discussion).
This data flows through to jitting (right?). If so we might want to look at what happens to jit codegen. I can do that separately though.
|
Since IBC is currently not used/supported should that code be removed? |
trylek
left a comment
There was a problem hiding this comment.
LGTM, thank you! Just for my curiosity, do the MIBC data restoration failures mean we first need to somehow seed the optimization data or are we going to need to make the restoration optional?
| <!-- dotnet-optimization dependencies --> | ||
| <optimizationwindows_ntx64MIBCRuntimeVersion>99.99.99-master-20210317.2</optimizationwindows_ntx64MIBCRuntimeVersion> | ||
| <optimizationwindows_ntx86MIBCRuntimeVersion>99.99.99-master-20210317.2</optimizationwindows_ntx86MIBCRuntimeVersion> | ||
| <optimizationlinuxx64MIBCRuntimeVersion>99.99.99-master-20210317.2</optimizationlinuxx64MIBCRuntimeVersion> |
There was a problem hiding this comment.
Is nuget package "optimization.MIBC.Runtime.99.99.99-master-20210317.2.nupkg" needed anywhere?
There was a problem hiding this comment.
Ideally the complex logic that is used to choose which one of these applies to a given platform will change to use the non-arch specific nuget package, but for now I just made it work without it.
|
FYI, this PR may lead to widespread changes in benchmark perf as static PGO data will now be available to the jit for some assemblies. Hopefully, many many improvements... |
UsingToolIbcOptimizationproperty