use packages instead of package report for packageInstallation and closure verification#49315
use packages instead of package report for packageInstallation and closure verification#49315Anipik merged 14 commits intodotnet:mainfrom Anipik:install
Conversation
|
Tagging subscribers to this area: @safern, @ViktorHofer, @Anipik Issue Details
This eliminated one of the use of the package reports which we intend to remove in the new packaging system. Arcade PR dotnet/arcade#7057
|
…osure verification
|
@safern @ViktorHofer @ericstj can you take another look here ? |
| <ExcludePackages Include="Microsoft.AspNetCore.Internal.Transport" /> | ||
| <ExcludePackages Include="$(ExcludePackages)" /> | ||
|
|
||
| <PackageReports Condition="'@(PackagesToTest)' == ''" Include="$(PackageReportDir)*.json" Exclude="@(ExcludePackages->'$(PackageReportDir)%(Identity).json')"/> |
There was a problem hiding this comment.
Presumably you'll clean this up later when we eliminate the harvesting and no longer need the harvesting check below?
There was a problem hiding this comment.
yes correct, hopefully we can clean up the entire reports related code after that.
|
@ViktorHofer @ericstj i addressed the major version issue with the regex. can u take a look ? |
| <Copy SourceFiles="@(TestSupportFiles)" DestinationFolder="%(TestSupportFiles.DestinationFolder)" /> | ||
| </Target> | ||
|
|
||
| <UsingTask TaskName="GetCompatiblePackageTargetFrameworks" AssemblyFile="$(DotNetPackageValidationAssembly)"/> |
There was a problem hiding this comment.
Curious, where does this project PackageReference the package validation package?
There was a problem hiding this comment.
Not sure about workflow, but all the packageReferences in tools.props are imported here
This eliminated one of the use of the package reports which we intend to remove in the new packaging system.
This also eliminates a lot of redundant test frameworks.
Arcade PR dotnet/arcade#7057