Skip to content

Move publishing off hosted ADO machines#49300

Merged
mmitche merged 3 commits intodotnet:release/5.0from
lukas-lansky:disk-space-workaround
Mar 9, 2021
Merged

Move publishing off hosted ADO machines#49300
mmitche merged 3 commits intodotnet:release/5.0from
lukas-lansky:disk-space-workaround

Conversation

@lukas-lansky
Copy link
Contributor

@lukas-lansky lukas-lansky commented Mar 8, 2021 •
edited
Loading

Just like #48521, but for 5.0 servicing that manifests the same error

@ghost
Copy link

ghost commented Mar 8, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lukas-lansky lukas-lansky requested review from MattGal and mmitche March 8, 2021 15:26
MattGal
MattGal approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to continuing to do this workaround but we need to check with @epananth and see if we can help her get this working on hosted again soon as this was supposed to be more temporary than it has proven to be.

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 8, 2021

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@lukas-lansky
Copy link
Contributor Author

lukas-lansky commented Mar 8, 2021

/azp run runtime

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 8, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@lukas-lansky
Copy link
Contributor Author

lukas-lansky commented Mar 9, 2021 

    System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildChainCustomTrustStore(chainBuildsSuccessfully: False, chainFlags: UntrustedRoot, testArguments: TrustedIntermediateUntrustedRoot) [FAIL]
      System.ArgumentOutOfRangeException : Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
      Stack Trace:
        /_/src/libraries/System.Security.Cryptography.X509Certificates/src/System/Security/Cryptography/X509Certificates/X509ChainElementCollection.cs(49,0): at System.Security.Cryptography.X509Certificates.X509ChainElementCollection.get_Item(Int32 index)
        /_/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs(290,0): at System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildChainCustomTrustStore(Boolean chainBuildsSuccessfully, X509ChainStatusFlags chainFlags, BuildChainCustomTrustStoreTestArguments testArguments)
        /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(384,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildChainCustomTrustStore(chainBuildsSuccessfully: True, chainFlags: NoError, testArguments: UntrustedIntermediateTrustedRoot) [FAIL]
      System.ArgumentOutOfRangeException : Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
      Stack Trace:
        /_/src/libraries/System.Security.Cryptography.X509Certificates/src/System/Security/Cryptography/X509Certificates/X509ChainElementCollection.cs(49,0): at System.Security.Cryptography.X509Certificates.X509ChainElementCollection.get_Item(Int32 index)
        /_/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs(290,0): at System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildChainCustomTrustStore(Boolean chainBuildsSuccessfully, X509ChainStatusFlags chainFlags, BuildChainCustomTrustStoreTestArguments testArguments)
        /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(384,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[...]

This seems like #48406.

@vcsjones @lukas-lansky
Use newer microsoft.com certificate chain in X.509 tests
ad80707 
The old certificate chain used a root certificate that is deprecated
and is starting to disappear from some trust stores. The removal of
the root certificate led to a few failing tests, and other tests not
running since they were conditional on the trust of that certificate.
@mmitche mmitche merged commit 5799b37 into dotnet:release/5.0 Mar 9, 2021
This was referenced Mar 10, 2021
Merged
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MattGal MattGal MattGal approved these changes

@mmitche mmitche mmitche approved these changes

@epananth epananth epananth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lukas-lansky @MattGal @mmitche @epananth @vcsjones