Skip to content

[main] Update dependencies from dotnet/xharness#49125

Merged
dotnet-maestro[bot] merged 3 commits intomainfrom
darc-main-4daebff3-4b6c-4aa6-92a0-2cd33d9787e9
Mar 4, 2021
Merged

[main] Update dependencies from dotnet/xharness#49125
dotnet-maestro[bot] merged 3 commits intomainfrom
darc-main-4daebff3-4b6c-4aa6-92a0-2cd33d9787e9

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 4, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20210304.2
  • Date Produced: 3/4/2021 11:25 AM
  • Commit: 6459101
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
543c755 
…10304.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.21153.1 -> To Version 1.0.0-prerelease.21154.1
@ghost
Copy link

ghost commented Mar 4, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
a6cac02 
…10304.2

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.21153.1 -> To Version 1.0.0-prerelease.21154.2
@premun
Copy link
Member

premun commented Mar 4, 2021

I lowered the frequency of the XHarness subscription to EveryDay

@premun
Copy link
Member

premun commented Mar 4, 2021 •
edited
Loading

@radical the failure here is probably related to: dotnet/xharness#492

Looks like the HelloiOS WASM returns this exit code but we don't read it?

XHarness command issued: wasm test-browser --app=. --engine=V8 --engine-arg=--stack-trace-limit=1000 --js-file=runtime.js --output-directory=/home/helixbot/work/A9450912/w/B52309AA/uploads/xharness-output --expected-exit-code=42 -- --run WebAssembly.Browser.AOT.Test.dll --testing -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
[13:46:04] info: Starting chromedriver with args: --incognito --headless --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-component-extensions-with-background-pages --disable-dev-shm-usage --disable-extensions --disable-features=TranslateUI --disable-ipc-flooding-protection --disable-renderer-backgrounding --force-color-profile=srgb --metrics-recording-only
Starting ChromeDriver 84.0.4147.0 (ff714bcb10c3356b1b1b2819148507a34fa4b1f8-refs/heads/master@{#768968}) on port 35959
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[13:46:06] info: MONO_WASM: Initializing mono runtime
[13:46:06] info: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
[13:46:06] info: mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28
[13:46:06] info: ret: 42
[13:46:06] info: WASM EXIT 0
[13:46:06] fail: Application has finished with exit code SUCCESS but 42 was expected
XHarness exit code: 71 (GENERAL_FAILURE)

@radical
[wasm] Update functional tests to xharness change in dotnet/xharness#492
2956066 


`xharness wasm test-browser` ignored `--expected-exit-code` before, but
the xharness PR added that option. So, the code here needs to be updated
to pass the exit code along as is.
@radical
Copy link
Member

radical commented Mar 4, 2021

@premun thanks for the catch. I have pushed a fix.

@dotnet-maestro dotnet-maestro bot merged commit b524799 into main Mar 4, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-4daebff3-4b6c-4aa6-92a0-2cd33d9787e9 branch March 4, 2021 21:04
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@premun @radical @stephentoub @karelz @danmoseley