Run dotnet.sh/cmd script before running dotnet restore#48375
Run dotnet.sh/cmd script before running dotnet restore#48375BruceForstall merged 2 commits intodotnet:masterfrom
Conversation
|
Issue: #48376 |
There was a problem hiding this comment.
I now realized that the error could be because we are not running bootstrap inside jitutils_directory. I deleted _cwd from run_command, but I guess it should be there and we should continue passing jitutils_directory as current working directory.
There was a problem hiding this comment.
oh; I deleted this arg because it was "extra", but maybe the cwd should be there? But I still think we should invoke the shell script first to ensure the .dotnet directory is there.
There was a problem hiding this comment.
Yes, cwd should be there so we can run it inside jitutils_directory. That should fix the problem.
And yes, we can run dotnet --info just to be sure.
16ffb2c to
1b8d37d
Compare
kunalspathak
left a comment
There was a problem hiding this comment.
LGTM with minor changes needed.
There was a problem hiding this comment.
Missing comma: _cwd=None,
1. Run dotnet for jitutils with jitutils dir as the current working dir. 2. Run dotnet.sh/cmd script before running bootstrap (and `dotnet restore`) to ensure `.dotnet` directory exists.
1b8d37d to
18dc018
Compare
|
Triggered superpmi collection https://dev.azure.com/dnceng/internal/_build/results?buildId=1000601&view=results |
No description provided.