Skip to content

Small pgo cleanup#48145

Merged
AndyAyersMS merged 1 commit intodotnet:masterfrom
AndyAyersMS:PgoCleanup
Feb 11, 2021
Merged

Small pgo cleanup#48145
AndyAyersMS merged 1 commit intodotnet:masterfrom
AndyAyersMS:PgoCleanup

Conversation

@AndyAyersMS
Copy link
Member

On the runtime side, intitialize the schema field so that the jit does not
internally think all optimized builds have pgo data with mismatched IL.

Quiet down some of the jit dumping when doing edge instrumentation.

Remove a few unused COMPlus vars from the jit.

On the runtime side, intitialize the schema field so that the jit does not
internally think all optimized builds have pgo data with mismatched IL.

Quiet down some of the jit dumping when doing edge instrumentation.

Remove a few unused COMPlus vars from the jit.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 11, 2021
@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

When did C++ get these default member initializers? I had no idea.

@sandreenko
Copy link
Contributor

When did C++ get these default member initializers? I had no idea.

~2011 I believe, http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2756.htm

@AndyAyersMS
Copy link
Member Author

@EgorBo maybe you can review this?

Copy link
Contributor

@briansull briansull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@AndyAyersMS
Copy link
Member Author

The installer build failure is tracked by #48169

##[error].packages\microsoft.dotnet.sharedframework.sdk\6.0.0-beta.21105.5\targets\sharedfx.targets(273,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) The following files are missing entries in the templated manifest:
pgort140.dll. Add these file names with extensions to the 'PlatformManifestFileEntry' item group for the runtime pack and corresponding ref pack to include them in the platform manifest.

@AndyAyersMS AndyAyersMS merged commit cb5431d into dotnet:master Feb 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants