Limit unique SNI to 63 chars in tests#47854
Merged
geoffkizer merged 2 commits intodotnet:masterfrom Feb 5, 2021
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe test generates SNI based on test name and argument to make it unique. However the SNI shouldn't be longer than 63 chars. Fixes #47378
|
geoffkizer
approved these changes
Feb 4, 2021
wfurt
approved these changes
Feb 5, 2021
Member
wfurt
left a comment
There was a problem hiding this comment.
LGTM.
Does the limitation comes from length of single DNS label? (I would expect SNI to be longer since that can be FQDN)
How did the old code manifest the problem?
Contributor
|
My understanding is that there's a limit of 255 on the whole host name, and also a limit of 63 on each part of the name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test generates SNI based on test name and argument to make it unique. However the SNI shouldn't be longer than 63 chars.
The PR also add another place when unique SNI is required for fix TLS1.3 test
Fixes #47378