Remove unused unicode header inclusion#47840
Merged
safern merged 1 commit intodotnet:masterfrom Feb 4, 2021
am11:feature/icu
Merged
Remove unused unicode header inclusion#47840safern merged 1 commit intodotnet:masterfrom am11:feature/icu
safern merged 1 commit intodotnet:masterfrom
am11:feature/icu
Conversation
`unicode/uclean.h` was added in bdc8955 for `u_init()` when the PR was WIP: https://github.com/dotnet/runtime/pull/37971/commits By the time PR was merged, `u_init()` was removed, so this header is not required by any configuration.
|
Tagging subscribers to this area: @tarekgh, @safern, @krwq Issue Details
By the time PR was merged, Fixes #47831
|
safern
approved these changes
Feb 4, 2021
Member
|
Timeouts on Android are being taken care of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unicode/uclean.hwas added in bdc8955 foru_init()when the PR wasWIP: https://github.com/dotnet/runtime/pull/37971/commits
By the time PR was merged,
u_init()was removed, so this header isnot required by any configuration.
Fixes #47831