Update the analyzer version in runtime and enable the TFM attributes on browser build#47789
Merged
buyaa-n merged 2 commits intodotnet:masterfrom Feb 4, 2021
Merged
Update the analyzer version in runtime and enable the TFM attributes on browser build#47789buyaa-n merged 2 commits intodotnet:masterfrom
buyaa-n merged 2 commits intodotnet:masterfrom
Conversation
… build, use latest analyzer
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jeffhandley
approved these changes
Feb 3, 2021
Anipik
approved these changes
Feb 3, 2021
stephentoub
reviewed
Feb 3, 2021
stephentoub
approved these changes
Feb 3, 2021
ViktorHofer
approved these changes
Feb 3, 2021
stephentoub
approved these changes
Feb 3, 2021
Contributor
Author
|
Test failures unrelated, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #44231 (comment) and #44257
By design, SDK adds
SupportedOSPlatofrm("targetPlatform")attribute intoAssemblyInfo.csfor multi-targeted projects build in runtime which causing CA1416 warnings mostly on.net5-Browsertargeted builds.We decided to suppress those warnings at the analyzer level, the work is done and merged into roslyn-analyzers repo and now we can dogfood that change. This PR:
SupportedOSPlatofrm("Browser")attribute added my MSBuild fromAssemblyInfo