[master] Update dependencies from mono/linker#47709
Merged
marek-safar merged 5 commits intomasterfrom Feb 4, 2021
Merged
Conversation
Microsoft.NET.ILLink.Tasks From Version 6.0.0-alpha.1.21079.1 -> To Version 6.0.0-alpha.1.21101.1
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
approved these changes
Feb 1, 2021
|
Tagging subscribers to this area: @ViktorHofer Issue DetailsThis pull request updates the following dependencies From https://github.com/mono/linker
|
Microsoft.NET.ILLink.Tasks From Version 6.0.0-alpha.1.21079.1 -> To Version 6.0.0-alpha.1.21101.2
Contributor
|
@mateoatr please resolve the IL2026 issues to unblock the merge |
Member
|
I have a fix for the linker issue in dotnet/linker#1798 After that change there are 3 new warnings (and some duplicates) which are valid and will need to be baselined (and eventually fixed): F:\dotnet\runtime2\src\libraries\System.Data.Common\src\System\Data\ColumnTypeConverter.cs(96,21): Trim analysis warning IL2026: System.Data.ColumnTypeConverter.ConvertTo(ITypeDescriptorContext,CultureInfo,Object,Type): Using method 'System.Type.GetType(String,Func<AssemblyName,Assembly>,Func<Assembly,String,Boolean,Type>,Boolean)' which has 'RequiresUnreferencedCodeAttribute' which can break functionality when trimming application code. The type might be removed.
F:\dotnet\runtime2\src\libraries\System.Private.CoreLib\src\System\Resources\ResourceReader.Core.cs(84,17): Trim analysis warning IL2026: System.Resources.ResourceReader.InitializeBinaryFormatter(): Using method 'System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Deserialize(Stream)' which has 'RequiresUnreferencedCodeAttribute' which can break functionality when trimming application code. BinaryFormatter serialization is not trim compatible because the Type of objects being processed cannot be statically discovered..
F:\dotnet\runtime2\src\libraries\System.Security.Cryptography.Primitives\src\System\Security\Cryptography\CryptoConfigForwarder.cs(20,13): Trim analysis warning IL2026: System.Security.Cryptography.CryptoConfigForwarder.BindCreateFromName(): Using method 'System.Security.Cryptography.CryptoConfig.CreateFromName(String)' which has 'RequiresUnreferencedCodeAttribute' which can break functionality when trimming application code. The default algorithm implementations might be removed, use strong type references like 'RSA.Create()' instead..
|
Member
|
dotnet/linker#1798 has been merged. A new build should update this PR (I assume) and the number of warnings should reduce substantially. Then we will need to baseline the new warnings in the PR. |
Microsoft.NET.ILLink.Tasks From Version 6.0.0-alpha.1.21079.1 -> To Version 6.0.0-alpha.1.21103.1
Contributor
|
@mateoatr could you add the 4 unique ones to the baseline? @vitek-karas there is still a lot of duplicated warnings |
Member
|
Some of them look like duplicates but they're not: ColumnTypeConverter.cs(96,21): ... 'System.Type.GetType(String,Func<AssemblyName,Assembly>,Func<Assembly,String,Boolean,Type>,Boolean,Boolean)'
ColumnTypeConverter.cs(96,21): ... 'System.Type.GetType(String,Func<AssemblyName,Assembly>,Func<Assembly,String,Boolean,Type>,Boolean)'
ColumnTypeConverter.cs(96,21): ... 'System.Type.GetType(String,Func<AssemblyName,Assembly>,Func<Assembly,String,Boolean,Type>)'
ColumnTypeConverter.cs(96,21): ... 'System.Type.GetType(String)' which has 'RequiresUnreferencedCodeAttribute'
ColumnTypeConverter.cs(96,21): ... 'System.Type.GetType(String,Boolean)'There does seem to be duplication on top of them though - I haven't seen it locally though. |
…thub.com:dotnet/runtime into darc-master-5f52e578-14f8-4808-8cf7-bb796d37745f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/mono/linker