JIT: let instrumentor decide which blocks to process#47597
Merged
AndyAyersMS merged 1 commit intodotnet:masterfrom Jan 29, 2021
Merged
Conversation
Forthcoming edge-based instrumentation will need to handle some BBF_INTERNAL blocks, so update main processing logic to accomodate this. Also have `fgInstrument` return proper phase status, so we get after-phase dumping if any instrumentation is added.
Member
Author
|
cc @dotnet/jit-contrib -- one "last" refactoring before layering on sparse edge profiling (#46882). |
Member
Author
|
/azp run runtime-jit-experimental |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
As with other recent PGO PRs, no unexpected failures in the "jit-experimental" runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forthcoming edge-based instrumentation will need to handle some BBF_INTERNAL
blocks, so update main processing logic to accomodate this.
Also have
fgInstrumentreturn proper phase status, so we get after-phasedumping if any instrumentation is added.