Add missing dlclose on error#47487
Merged
vitek-karas merged 1 commit intodotnet:masterfrom Feb 4, 2021
Merged
Conversation
If the symbol is not found, close the library before returning false. Otherwise, the library is not stored anywhere and never cleaned up.
|
Tagging subscribers to this area: @vitek-karas, @agocke Issue DetailsIf the symbol is not found, close the library before returning false. Otherwise, the library is not stored anywhere and never cleaned up.
|
Member
|
@omajid - thanks a lot for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a resource leak, but I am not sure.
If the symbol is not found, close the library before returning false.
Otherwise, the library is not stored anywhere and never cleaned up.