Skip to content

Exporting more diagnostics symbols from the singlefile host#47451

Merged
VSadov merged 1 commit intodotnet:masterfrom
VSadov:debExports
Jan 26, 2021
Merged

Exporting more diagnostics symbols from the singlefile host#47451
VSadov merged 1 commit intodotnet:masterfrom
VSadov:debExports

Conversation

@VSadov
Copy link
Member

@VSadov VSadov commented Jan 26, 2021 •
edited
Loading

Re:dotnet/diagnostics#1764

Added, in addition to DotNetRuntimeInfo:

  • Windows:
    g_CLREngineMetrics
    CLRJitAttachState

  • Unix:
    g_dacTable

  • All:
    MetaDataGetDispenser

@ghost
Copy link

ghost commented Jan 26, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Re:dotnet/diagnostics#1764

Added (in addition to DotNetRuntimeInfo):

  • Windows:
    g_CLREngineMetrics
    CLRJitAttachState

  • Unix:
    g_dacTable

  • All:
    MetaDataGetDispenser

Author: VSadov
Assignees: -
Labels:

area-Diagnostics-coreclr
Milestone: -

@VSadov
Copy link
Member Author

VSadov commented Jan 26, 2021

Windows:

    ordinal hint RVA      name

          3    0 02DCAA1C CLRJitAttachState = ?CLRJitAttachState@@3KA (unsigned long CLRJitAttachState)
          4    1 02DABF30 DotNetRuntimeInfo = ?DotNetRuntimeInfo@@3U_RuntimeInfo@@A (struct _RuntimeInfo DotNetRuntimeInfo)
          5    2 007FD470 MetaDataGetDispenser = MetaDataGetDispenser
          2    3 02DA6A90 g_CLREngineMetrics = ?g_CLREngineMetrics@@3UtagCLR_ENGINE_METRICS@@A (struct tagCLR_ENGINE_METRICS g_CLREngineMetrics)

@VSadov
Copy link
Member Author

VSadov commented Jan 26, 2021

Linux:

nm -D --defined-only /SSD/vsadov/hosting01/runtime/artifacts/bin/linux-x64.Release/corehost/singlefilehost
0000000000bdce98 D DotNetRuntimeInfo
0000000000bef6b4 B g_dacTable
00000000005026d0 T MetaDataGetDispenser
0000000000000000 A V1.0

@VSadov VSadov requested a review from mikem8361 January 26, 2021 03:44
@VSadov
Copy link
Member Author

VSadov commented Jan 26, 2021

macOS:

nm -gU  ./artifacts/bin/osx-x64.Release/corehost/singlefilehost
000000010081b180 D _DotNetRuntimeInfo
00000001000548a0 T _MetaDataGetDispenser
0000000100849c58 S _g_dacTable

@VSadov
Copy link
Member Author

VSadov commented Jan 26, 2021

Thanks!!

@VSadov VSadov merged commit 8c6e3e9 into dotnet:master Jan 26, 2021
@VSadov VSadov deleted the debExports branch January 26, 2021 06:06
@VSadov
Copy link
Member Author

VSadov commented Jan 28, 2021

/backport to release/6.0-preview1

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2021

Started backporting to release/6.0-preview1: https://github.com/dotnet/runtime/actions/runs/516879747

@github-actions github-actions bot mentioned this pull request Jan 28, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikem8361 mikem8361 mikem8361 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VSadov @mikem8361