Public sign ilasm output by default#47448
Merged
jkotas merged 1 commit intodotnet:masterfrom Jan 26, 2021
Merged
Conversation
Member
Author
Member
|
Looks ok, I don’t suppose this would break anyone? |
ericstj
approved these changes
Jan 26, 2021
Member
Author
|
I do not expect that this will break anyone. We can always add command line option for it if necessary. I have started by adding a command line option, but then decided to keep it simple and just set it by default. |
Member
|
If we do make the commandline option we should make sure to update the ILProj SDK to honor the publicsign property so that we'll set it (and not regress the fix where we needed it). |
Contributor
|
I took a look, Looks like it should work to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47426