Fix for 46529 - Unexpected behaviour of ulong -> int cast#47418
Merged
briansull merged 2 commits intodotnet:masterfrom Jan 26, 2021
Merged
Fix for 46529 - Unexpected behaviour of ulong -> int cast#47418briansull merged 2 commits intodotnet:masterfrom
briansull merged 2 commits intodotnet:masterfrom
Conversation
Move check for side-effect and don't push the cast for shifts of 32 to 63 Added test Runtime_46239.cs
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Contributor
Author
|
Fixes #46529 |
Contributor
Author
|
@dotnet/jit-contrib PTAL |
Member
|
@briansull @JulieLeeMSFT this looks like a good candidate for both 5.0 and 3.1 servicing... |
Contributor
Author
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/529711052 |
Contributor
|
@briansull backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix for issue 46529 Move check for side-effect and don't push the cast for shifts of 32 to 63 Added test Runtime_46239.cs
error: sha1 information is lacking or useless (src/coreclr/jit/morph.cpp).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix for issue 46529 Move check for side-effect and don't push the cast for shifts of 32 to 63 Added test Runtime_46239.cs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
Author
|
This regression was introduced by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move check for side-effect and don't push the cast down for shifts of 32 to 63
Added test Runtime_46239.cs