Add test coverage for SzArray constructors#47400
Merged
MichalStrehovsky merged 3 commits intodotnet:masterfrom Jan 26, 2021
Merged
Add test coverage for SzArray constructors#47400MichalStrehovsky merged 3 commits intodotnet:masterfrom
MichalStrehovsky merged 3 commits intodotnet:masterfrom
Conversation
I couldn't find a single occurence of `[]::` in the test tree, so I assume we don't have any coverage for this. Arrays are normally allocated with the dedicated `newarr` IL instruction. The ECMA-335 specification says "All zero-based, one-dimensional arrays are created using newarr, not newobj.". Nevertheless, they do have a constructor and apparently code out there uses it. Also adding coverage for the constructor that creates a jagged array. Regression test for dotnet/runtimelab#578.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't find a single occurence of
[]::in the test tree, so I assume we don't have any coverage for this.Arrays are normally allocated with the dedicated
newarrIL instruction. The ECMA-335 specification says "All zero-based, one-dimensional arrays are created using newarr, not newobj.". Nevertheless, they do have a constructor and apparently code out there uses it.Also adding coverage for the constructor that creates a jagged array.
Regression test for dotnet/runtimelab#578.
We should bump this down to Pri-1 before merging, but I want the CI to run on this.