Fix race conditions with resolving singletons in DI#47310
Merged
maryamariyan merged 14 commits intodotnet:masterfrom Jan 23, 2021
Merged
Fix race conditions with resolving singletons in DI#47310maryamariyan merged 14 commits intodotnet:masterfrom
maryamariyan merged 14 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsTODO:
|
davidfowl
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Show resolved
Hide resolved
davidfowl
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jan 22, 2021
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderContainerTests.cs
Outdated
Show resolved
Hide resolved
- Reduce code lines for class definitions
Contributor
Author
|
Applied PR feedback per commit so it's easier to review. |
davidfowl
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jan 22, 2021
...ies/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngineScope.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jan 22, 2021
...ies/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngineScope.cs
Outdated
Show resolved
Hide resolved
davidfowl
approved these changes
Jan 22, 2021
771f581 to
86a427b
Compare
eerhardt
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Show resolved
Hide resolved
eerhardt
reviewed
Jan 22, 2021
...raries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Jan 22, 2021
Member
eerhardt
left a comment
There was a problem hiding this comment.
Looks good. Nice work fixing these issues.
Contributor
Author
|
Thanks for the reviews, glad we're getting to fit this into preview 1. |
davidfowl
approved these changes
Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR and comments: #46157 (comment)