Parse method call chain model file and resolve methods#47302
Merged
nattress merged 2 commits intodotnet:masterfrom Jan 22, 2021
Merged
Parse method call chain model file and resolve methods#47302nattress merged 2 commits intodotnet:masterfrom
nattress merged 2 commits intodotnet:masterfrom
Conversation
Contributor
nattress
commented
Jan 21, 2021
- Resolve methods from Azure profile trace building a list of caller->callees with counts to use in compilation heuristics
- Resolves the two main forms of methods we see in the traces:
* Resolve methods from Azure profile trace building a list of caller->callees with counts to use in compilation heuristics * Resolves the two main forms of methods we see in the traces: ``` // System.Core.ni.dll!System.Linq.Enumerable+WhereSelectEnumerableIterator`2[System.__Canon,System.__Canon].MoveNext Microsoft.Azure.Monitoring.WarmPath.FrontEnd.Middleware.SecurityMiddlewareBase`1+<Invoke>d__6[System.__Canon]!MoveNext ```
trylek
approved these changes
Jan 21, 2021
Member
trylek
left a comment
There was a problem hiding this comment.
Looks great modulo two comments one of which is important as it will likely crash your current build. Thank you!
src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/CallChainProfile.cs
Outdated
Show resolved
Hide resolved
trylek
approved these changes
Jan 21, 2021
Member
trylek
left a comment
There was a problem hiding this comment.
Looks spotless now, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.