Supply file version info for the jitinterface native library#47300
Merged
janvorli merged 1 commit intodotnet:masterfrom Jan 22, 2021
Merged
Supply file version info for the jitinterface native library#47300janvorli merged 1 commit intodotnet:masterfrom
janvorli merged 1 commit intodotnet:masterfrom
Conversation
During my work on switching over framework library crossgenning to use Crossgen2 I noticed that jitinterface is missing the file version information. This change fixes the issue. Thanks Tomas
MichalStrehovsky
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my work on switching over framework library crossgenning
to use Crossgen2 I noticed that jitinterface is missing the
file version information. This change fixes the issue.
Thanks
Tomas
P.S. Big thank you to JanV for helping me out with cmake intricacies.
/cc @dotnet/crossgen-contrib