Disable sourcelink locally consistently#47297
Merged
ViktorHofer merged 1 commit intodotnet:masterfrom Jan 22, 2021
Merged
Conversation
|
Tagging subscribers to this area: @ViktorHofer Issue DetailsWith dotnet/arcade@1530d9c it's now possible to build the repo without source link being enabled. Previously the generation of the native versions file was failing without source link. Disabling source link by default locally for the runtimes and installer - it was already disabled for all libraries.
|
Anipik
approved these changes
Jan 22, 2021
Member
Author
|
Test failure is #47340. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47130
With dotnet/arcade@1530d9c it's now possible to build the repo without source link being enabled. Previously the generation of the native versions file was failing without source link. Disabling source link by default locally for the runtimes and installer - it was already disabled for all libraries.