Refactor some HTTP remote server tests#47252
Merged
geoffkizer merged 13 commits intodotnet:masterfrom Jan 22, 2021
Merged
Conversation
added 13 commits
January 20, 2021 14:13
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsMove existing remote server tests in HttpClientHandlerTest.cs into a new file, HttpClientHandlerTest.RemoteServer.cs. This eliminates test run duplication caused by multiple derivations of HttpClientHandlerTest.cs. Also enable a couple remote server tests to run against more remote server configurations, and some minor cleanup. This reduces the number of outerloop tests run by about 12%. Contributes to #30205
|
Contributor
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Jan 21, 2021
Member
stephentoub
left a comment
There was a problem hiding this comment.
Assuming the tests that were moved weren't also edited (since I didn't review all the tests individually), LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move existing remote server tests in HttpClientHandlerTest.cs into a new file, HttpClientHandlerTest.RemoteServer.cs. This eliminates test run duplication caused by multiple derivations of HttpClientHandlerTest.cs.
Also enable a couple remote server tests to run against more remote server configurations, and some minor cleanup.
This reduces the number of outerloop tests run by about 12%.
Contributes to #30205
Contributes to #1583