Skip to content

Include crossgen2 tool when crossgening SPC.#47216

Merged
sandreenko merged 1 commit intodotnet:masterfrom
sandreenko:includeCrossgen2WithNativeSPC
Jan 20, 2021
Merged

Include crossgen2 tool when crossgening SPC.#47216
sandreenko merged 1 commit intodotnet:masterfrom
sandreenko:includeCrossgen2WithNativeSPC

Conversation

@sandreenko
Copy link
Contributor

Jit developers were used to build with clr.runtime+Clr.CoreLib+Clr.NativeCoreLib and it was self-sufficient. Now Clr.NativeCoreLib requires crossgen2 so add them to the subset so we can iterate without building other tools (like R2R dump).

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, thank you!

@sandreenko
Copy link
Contributor Author

@briansull it will fix the issue that you reported, cc @dotnet/jit-contrib

@sandreenko sandreenko merged commit 2864b37 into dotnet:master Jan 20, 2021
@sandreenko sandreenko deleted the includeCrossgen2WithNativeSPC branch January 20, 2021 23:18
@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants