Disable 2 regex tests on Linux by danmoseley · Pull Request #47209 · dotnet/runtime

danmoseley · 2021-01-20T04:27:10Z

Tracing has proven that these tests are falling victim to the OOM killer on Ubuntu 18.04.
Since they're not testing anything OS specific, limit them to Windows where they can page if necessary.

ghost · 2021-01-20T04:27:18Z

Tagging subscribers to this area: @eerhardt, @pgovind
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #46516

Tracing has proven that these tests are falling victim to the OOM killer on Ubuntu 18.04.
Since they're not testing anything OS specific, limit them to Windows where they can page if necessary.

Author:	danmosemsft
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

ghost · 2021-01-20T04:36:42Z

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes, a condition that will be fulfilled in about 29 seconds. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Fix regex test OOM

fa6909f

ghost added the area-System.Text.RegularExpressions label Jan 20, 2021

stephentoub approved these changes Jan 20, 2021

View reviewed changes

danmoseley added the auto-merge label Jan 20, 2021

ghost merged commit 5aef85a into dotnet:master Jan 20, 2021

ghost locked as resolved and limited conversation to collaborators Feb 19, 2021

danmoseley deleted the regex.oom branch September 6, 2021 23:38

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable 2 regex tests on Linux#47209

Disable 2 regex tests on Linux#47209
1 commit merged intodotnet:masterfrom
danmoseley:regex.oom

danmoseley commented Jan 20, 2021

Uh oh!

ghost commented Jan 20, 2021

Uh oh!

ghost commented Jan 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

danmoseley commented Jan 20, 2021

Uh oh!

ghost commented Jan 20, 2021

Uh oh!

ghost commented Jan 20, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.