Update the ComWrappers API by AaronRobinsonMSFT · Pull Request #47073 · dotnet/runtime

AaronRobinsonMSFT · 2021-01-16T02:45:26Z

Add support for the new Aggregated and Unwrap flags in ComWrappers.

ghost · 2021-01-16T02:45:31Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Add missing contracts.

Remove extra AddRef() in ComWrappers global marshalling scenario.

AaronRobinsonMSFT · 2021-01-20T04:36:00Z

/avp help

AaronRobinsonMSFT · 2021-01-20T04:36:56Z

/azp help

azure-pipelines · 2021-01-20T04:37:01Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

AaronRobinsonMSFT · 2021-01-20T04:37:14Z

/azp help

azure-pipelines · 2021-01-20T04:37:19Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

AaronRobinsonMSFT · 2021-01-20T04:37:38Z

/azp list

azure-pipelines · 2021-01-20T04:37:43Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning coreclr-gc-simulator runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly sync-runtime-to-mono runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr clrinterpreter runtime-coreclr crossgen2-composite gcstress runtime-libraries-mono outerloop runtime-staging

AaronRobinsonMSFT · 2021-01-20T04:38:18Z

/azp run runtime

azure-pipelines · 2021-01-20T04:38:47Z

Azure Pipelines successfully started running 1 pipeline(s).

src/coreclr/interop/interoplib.cpp

src/coreclr/vm/interoplibinterface.cpp

src/coreclr/interop/interoplib.cpp

the scenario is for aggregation.

ghost · 2021-01-21T02:15:38Z

Hello @AaronRobinsonMSFT!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Update the ComWrappers API

061ed8c

Add support for the new Aggregated and Unwrap flags in ComWrappers.

AaronRobinsonMSFT added the area-Interop-coreclr label Jan 16, 2021

AaronRobinsonMSFT added this to the 6.0.0 milestone Jan 16, 2021

ghost added the new-api-needs-documentation label Jan 16, 2021

AaronRobinsonMSFT added 2 commits January 15, 2021 21:50

ARM/ARM64 build issues.

5d3c0a0

Add missing contracts.

Add test for unwrap logic.

40a05ee

Remove extra AddRef() in ComWrappers global marshalling scenario.

AaronRobinsonMSFT marked this pull request as ready for review January 20, 2021 04:33

jkoritzinsky reviewed Jan 20, 2021

View reviewed changes

src/coreclr/interop/interoplib.cpp Show resolved Hide resolved

src/coreclr/vm/interoplibinterface.cpp Outdated Show resolved Hide resolved

src/coreclr/interop/interoplib.cpp Show resolved Hide resolved

Review feedback.

da2402c

jkoritzinsky approved these changes Jan 20, 2021

View reviewed changes

Add negative test for passing non-null inner without indicating

821290b

the scenario is for aggregation.

AaronRobinsonMSFT added the auto-merge label Jan 21, 2021

ghost merged commit 3c2cdac into dotnet:master Jan 21, 2021

AaronRobinsonMSFT deleted the runtime44446 branch January 21, 2021 06:40

ghost locked as resolved and limited conversation to collaborators Feb 20, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the ComWrappers API#47073

Update the ComWrappers API#47073
5 commits merged intodotnet:masterfrom
AaronRobinsonMSFT:runtime44446

AaronRobinsonMSFT commented Jan 16, 2021 •

edited

Loading

Uh oh!

ghost commented Jan 16, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

AaronRobinsonMSFT commented Jan 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 16, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

AaronRobinsonMSFT commented Jan 20, 2021

Uh oh!

azure-pipelines bot commented Jan 20, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jan 21, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AaronRobinsonMSFT commented Jan 16, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.