Enable HttpHeaderValueCollection.GetEnumerator to return an empty singleton#47010
Merged
stephentoub merged 2 commits intodotnet:masterfrom Jan 15, 2021
Merged
Enable HttpHeaderValueCollection.GetEnumerator to return an empty singleton#47010stephentoub merged 2 commits intodotnet:masterfrom
stephentoub merged 2 commits intodotnet:masterfrom
Conversation
…gleton An empty collection is common. We can avoid the enumerator allocation in such cases.
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAn empty collection is common. We can avoid the enumerator allocation in such cases.
|
geoffkizer
reviewed
Jan 14, 2021
src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaderValueCollection.cs
Outdated
Show resolved
Hide resolved
geoffkizer
approved these changes
Jan 14, 2021
stephentoub
commented
Jan 14, 2021
src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaderValueCollection.cs
Outdated
Show resolved
Hide resolved
…HeaderValueCollection.cs
|
Hello @stephentoub! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty collection is common. We can avoid the enumerator allocation in such cases.
cc: @geoffkizer